posthog

posthog copied to clipboard

Problem

• boolean values passed as strings are never converted to bool

Changes

• we do bool conversions for regular filters. apply that logic to this too

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/hogql/property.py

Function	Unhandled Issue
property_to_expr	TypeError: Property.init() missing 1 required positional argument: 'key' posthog.ta... Event Count: 17
property_to_expr	Cohort.DoesNotExist: Cohort matching query does not exist. posthog.tasks.tasks.process_... Event Count: 7
property_to_expr	NotImplementedError: property_to_expr for element selector only supports exact and is_not operators, not regex ... Event Count: 4
property_to_expr	NotImplementedError: property_to_expr for element selector only supports exact and is_not operators, not icontains ... Event Count: 1

📄 File: posthog/hogql/query.py (Click to Expand)

Function	Unhandled Issue
execute_hogql_query	CHQueryErrorUnknownIdentifier: DB::Exception: Missing columns: '--events__override.distinct_id' '--events__override.person_id'... ... Event Count: 2.3k
execute_hogql_query	CHQueryErrorNoCommonType: DB::Exception: There is no supertype for types String, Float64 because some of them are String/Fi... ... Event Count: 217
execute_hogql_query	CHQueryErrorTypeMismatch: DB::Exception: Cannot convert string 17.4.1 to type Float64: while executing 'FUNCTION equals(toF... ... Event Count: 152
execute_hogql_query	CHQueryErrorIllegalTypeOfArgument: DB::Exception: Illegal type String of argument for aggregate function avg. Stack trace: ... Event Count: 108
execute_hogql_query	ValidationError: 1 validation error for HogQLQueryResponse posthog.tasks.tasks.process_... Event Count: 101

---

_{Did you find this useful? React with a 👍 or 👎}