posthog

posthog copied to clipboard

Problem

The stats table query doesn't use the sessions table to e.g. calculate bounce rate, and it could do which would give it a performance boost.

Changes

Use the sessions table. Additionally, expand the test coverage. Fixes a bug where using a path filter broke the bounce rate and scroll depth calculation

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added many tests

It's also behind a FF still

Size Change: +524 B (0%)

Total Size: 1.05 MB

ℹ️ View Unchanged

Filename	Size	Change
frontend/dist/toolbar.js	1.05 MB	+524 B (0%)

_{compressed-size-action}

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ CHQueryErrorBadArguments: DB::Exception: Dictionary (channel_definition_dict) not found: While processing multiIf(match(n... posthog.tasks.tasks.process_query_task View Issue

_{Did you find this useful? React with a 👍 or 👎}