Polymesh icon indicating copy to clipboard operation
Polymesh copied to clipboard

[WIP] MESH-1879/ If a validator stash is moved between identies then running_count may be incorrect

Open JMoore96 opened this issue 3 years ago • 2 comments

changelog

modified logic

  • made minor changes to running_count insert and delete logic

data migration required

  • called Identity add_account_key_ref_count function on current validators

JMoore96 avatar Oct 11 '22 02:10 JMoore96

Codecov Report

Merging #1333 (4fb6dba) into develop (4fb6dba) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 4fb6dba differs from pull request most recent head a7a23fa. Consider uploading reports for the commit a7a23fa to get more accurate results

@@           Coverage Diff            @@
##           develop    #1333   +/-   ##
========================================
  Coverage    43.95%   43.95%           
========================================
  Files          141      141           
  Lines        30043    30043           
========================================
  Hits         13206    13206           
  Misses       16837    16837           

codecov[bot] avatar Oct 11 '22 02:10 codecov[bot]

@JMoore96 We will need to merge this PR to fix those compile errors: https://github.com/PolymeshAssociation/Polymesh/pull/1322

I added a change to the storage_migrate_on macro to allow using a different name then StorageVersion for our storage versions. This will allow you to use PolymeshStorageVersion in this PR.

Neopallium avatar Oct 11 '22 12:10 Neopallium