pba-content

pba-content copied to clipboard

Still trying to listen, similar to #552. Some comments and feedback so far:

• Junction: You could use BoundedVec<Junction, Max> and you can match on that as a slice almost equally like a tuple, probably better to justify it mainly as saving the Compact<u32> byte by using enum Junctions?
• MultiAsset creation into examples could show the output as well.
• Why re-anchroing has to happen separately: A felt a bit of confusion there as well. Can you have all the re-anchoring logic be part of your multi-asset creation function and just use a ‘Identity-like’ Re-Anchoring? After talking to Gorka he explained that this has to do with the fact that some XCM messages are executed both locally and externally. Now clear to me, but perhaps can be explained differently to sudent.
• Idea: DNS for XCM locations?

• Junctions: having an enum with multiple variants vs BoundedVec means no allocations, but also the size of the struct is very big on the stack (8 * mem::size_of::<Junction>() + 1).
• DNS for XCM locations: can it be a separate (common good) parachain? More like a proxy, that acts as a link shortener.