PokemonUnity icon indicating copy to clipboard operation
PokemonUnity copied to clipboard

Beta enum refactor

Open herbertmilhomme opened this issue 4 years ago • 0 comments

Using Enumeration classes instead of enum types Doing something like that will convert every enum value into an int. Which means no need to convert and any value should can be used to check if valid or not. Which makes adding new pokemons easier to manage in the future As well as maybe even easier for unity or online server-client relationships... but you miss out on drop-down feature and multiple choice (since any int value can be possible or accepted) Maybe for pokemon enums the possibility for both a class and enum can exist side by side, instead of one or the other...

Status

  • [ ] Ready
  • [x] In development
  • [ ] Hold

Description

Testing

Concerns, notes, etc.

i think the rewrite is turning out for the better... after having recent talks with @MyzTyn because the data isnt being loaded dynamically by database, it might be easier on game ram/memory, and also address the whole sqlite issues we were dealing with in previous updates.

Related issues

Related PRs

herbertmilhomme avatar Jan 18 '22 04:01 herbertmilhomme