sprites icon indicating copy to clipboard operation
sprites copied to clipboard

Project Pokemon Sprite Index

Open HRKings opened this issue 4 years ago • 12 comments

Would be possible to used the animated sprites from Project Pokemon Sprite Index ? The 3D model GIFs are really good. I was working on a project that maps the named sprites to the PokeAPI IDs, so we could use them.

HRKings avatar Oct 24 '21 08:10 HRKings

Hello, don't we already have the animated sprites? Oh, no, we only have the BW ones.

Then yes! Surely. I think those ones come directly from the ROMs

Naramsim avatar Oct 25 '21 17:10 Naramsim

I don't even think we need to change the names of the images.

Naramsim avatar Oct 25 '21 17:10 Naramsim

The important part is that if the sprites are modified by someone else other than Nintendo, we mention them.

As we did here: https://github.com/PokeAPI/sprites#black-and-white

Naramsim avatar Oct 25 '21 17:10 Naramsim

I don't even think we need to change the names of the images.

They have various names that don't match anything on the PokeAPI (like mr-.mime or the gigantamax forms that are {pokemon}-gigantamax instead of {pokemon}-gmax). I don't know how this really can influence the mapping on the build process.

The way that I mapped them is: {speciesID}-form or only the speciesID and the folder structure is the same used by PokeAPI

HRKings avatar Oct 25 '21 17:10 HRKings

The important part is that if the sprites are modified by someone else other than Nintendo, we mention them.

As we did here: https://github.com/PokeAPI/sprites#black-and-white

Yeah, they have lists of everyone that contributed to the index (uploading the images or the cleaning the sprites), we could reference the lists or link to it

HRKings avatar Oct 25 '21 17:10 HRKings

The way that I mapped them is: {speciesID}-form or only the speciesID and the folder structure is the same used by PokeAPI

If the images are form-specific, then you can use the Pokeapi's ID of the pokemon + the form (https://pokeapi.co/api/v2/pokemon-form/arceus-bug -> 493-bug.png). If they are for varieties, you can use the Pokeapi's ID of the pokemon.

Yeah, they have lists of everyone that contributed to the index (uploading the images or the cleaning the sprites), we could reference the lists or link to it

I saw, I'd put the names and the link to their forum. But first, I'd ask them. Do you have an account for that forum? We could message https://projectpokemon.org/home/profile/1731-theslayer/. If you don't have it I'll ask him.

Naramsim avatar Oct 25 '21 17:10 Naramsim

If the images are form-specific, then you can use the Pokeapi's ID of the pokemon + the form (https://pokeapi.co/api/v2/pokemon-form/arceus-bug -> 493-bug.png). If they are for varieties, you can use the Pokeapi's ID of the pokemon.

Do forms have a isVariety flag or something like that ? To make it easier to map. I did speciesID + the form name because it was easier to map from only the names

I saw, I'd put the names and the link to their forum. But first, I'd ask them. Do you have an account for that forum? We could message https://projectpokemon.org/home/profile/1731-theslayer/. If you don't have it I'll ask him.

I don't have, but I am on their Discord, I asked them here

HRKings avatar Oct 25 '21 17:10 HRKings

Update: image image

HRKings avatar Oct 25 '21 17:10 HRKings

Do forms have a isVariety flag or something like that ? To make it easier to map. I did speciesID + the form name because it was easier to map from only the names.

forms -> /pokemon-form/493/ variety -> /pokemon/493/ species -> /pokemon-species/493/

@andre23arruda just submitted a PR for this issue. Do you think it's a valid PR?

Naramsim avatar Oct 26 '21 09:10 Naramsim

Well, it seems to come from the Sprite Index too. But there are some things to look:

  • Not everything can me mapped back to PokeAPI, like all of alcremie variantions. They don't appear on PokeAPI, and in the Sprite Index there are a lot of alcremies.
  • There is a lot of models from other generations, including pokemons that don't appear in SWSH, so I recommend we create a other/models for example

HRKings avatar Oct 26 '21 15:10 HRKings

forms -> /pokemon-form/493/ variety -> /pokemon/493/ species -> /pokemon-species/493/

And on Arceus species, the varieties only list the base form

Aren't megas and gmax forms ? They have an entry for varieties too, right ?

My main problem was when IDs did conflict, like giratina and Unown-H. Giratina, has both namings in the sprites URLs, despite origin being a form

HRKings avatar Oct 26 '21 16:10 HRKings

Arceus' species endpoint not having a list of varieties is just a quirk of it with a few others, like Silvally and the unowns. Basically, if the form doesn't have a 10xxx pokemon id number, then it won't have the other varieties listed at the pokemon-species endpoint. All the megas and gmax forms have a unique pokemon id. You can see the full list of pokemon id's on the pokemon.csv.

How did Giratina and unown-h conflict for you? I see that giratina-origin has a pokemon id of 10007, but unown-h has a pokemon-form id of 10007. Also, you can label giratina-origin as 487-origin.gif or as 10007.gif and either will work correctly, although try to prefer the 10xxx if you can.

C-Garza avatar Oct 27 '21 01:10 C-Garza

Hope your query is resolved? If not, you can reopen it anytime.

devmike123 avatar Jan 02 '23 18:01 devmike123