pokeapi

pokeapi copied to clipboard

move/11 has a "name" parameter of "vice-grip" (with a C) but at least one 'mon, pokemon/98 (Krabby), has this move listed with a "name" parameter of "vise-grip" (with an S) - key path moves[0].move.name.

This seems to be a fairly recent change as it's broken my import script which was working yesterday IIRC.

Oddly, I can't find "vise-grip" anywhere in the code base so I'm not sure why this is happening. Maybe it was a temporary hiccup but the bad data is being cached somewhere?

After further research, I've found that this commit from way back in May changed what had previously been "vice-grip" into "vise-grip", and this commit from December 27 flipped it back around again. So I'm guessing the data for the move is just being served from a stale cache.

For my own purposes the "name" of the move can be either "vice-grip" or "vise-grip" so long as it is consistent between the move data and the monster data, but I'm sure for others this will cause major issues if their own data structures are dependent on that being consistent. Maybe we should switch it back to "vise-grip" for now? Edit: As the upstream data has used "vice-grip" since 2013, I guess that is actually more "correct." Nonetheless the data is inconsistent between move and monster.

You are right, I noticed that move name changed when syncing the data. Apparently it was renamed vise grip in gen8. When we made our own fork of the gen8 data, we used the new name. But it looks like Veekun upstream wants to keep the old name, vice-grip as seen here in this review. I personally think it should also stay vice-grip as well, as it has been that name since gen1. Maybe you can open an issue on Veekun, as it is now the newer spelling and future games might use that spelling instead. I know that feint attack used to be called faint attack for instance, but Veekun uses the newer feint attack.