WTAL-Uncertainty-Modeling
WTAL-Uncertainty-Modeling copied to clipboard
An Error implement about `nms`
These two lines should not add 1 for compute areas:
https://github.com/Pilhyeon/WTAL-Uncertainty-Modeling/blob/ea630d41e2fc92d523257524690cc6de921e4773/utils.py#L101
https://github.com/Pilhyeon/WTAL-Uncertainty-Modeling/blob/ea630d41e2fc92d523257524690cc6de921e4773/utils.py#L111
Reference the implement of temporal nms in mmaction2
https://mmaction2.readthedocs.io/en/latest/api.html#id26
The implementation of mmaction2 might be slightly different from ours. In ours, the temporal intervals are determined in an inclusive way, so we need to add 1 to compute areas (e.g., the interval [1, 1] has its area of 1.)
yeah, I have noticed that, and I think if we want to compute the real temporal area, for example, [1, 2], the time lasted 1 second maybe more intuitive, and such as [1, 1], the time lasted 0 second.
Yes, I agree with you: it is more intuitive as the temporal slicing in python also works in that way. I will consider representing the intervals in that way in future work. Thanks for the suggestion.