Peter Wippermann

Results 21 comments of Peter Wippermann
trafficstars

@kcooney How should I remove the formatting? Sorry, but Eclipse always formats the whole file and it's not my fault that this file wasn't formatted accordingly before :-/

Maybe we should have another PR to format all files under `org.junit.*` once and for good?

Regarding your feedback, @kcooney : - I'd like to reuse functionality which easily finds and processes annotations for me. For that cause `BlockJUnit4ClassRunner.getTestRules(Object, TestClass)` and `Suite.getSuiteClasses(Class)` are very handy. I...

Which files are you complaining about, @kcooney ? - `BlockJUnit4ClassRunner` is indeed a victim of formatting the whole file - the "@@ -1,130 +1,130 @@ diff" of `Suite` is a...

I reported #1350 to get the code style right. Afterwards comparing the code should be easy again.

You were right! I reformatted Suite and BloackJUnit4RunnerWithParameters with Unix line endings and UTF-8 as explained [here](http://stackoverflow.com/a/1887619/193705). The extraneous diffs are gone now. Still, I'm wondering why not all the...

For the period before this PR can be merged, I set up a project that provides exactly this functionality and makes it available for reuse: https://github.com/PeterWippermann/parameterized-suite