docker-perl icon indicating copy to clipboard operation
docker-perl copied to clipboard

Set default ENTRYPOINT

Open zakame opened this issue 6 years ago • 5 comments

This installs and sets tini as the default ENTRYPOINT for Perl images, to enable Perl programs in containers to handle signals correctly, particularly on SIGINT/SIGTERM.

Ref. #44

zakame avatar Aug 05 '19 00:08 zakame

Bump? (also there are conflicts that would need some TLC)

mohawk2 avatar Sep 14 '20 11:09 mohawk2

Yes, the conflicts are from the lone commit regenerating Dockerfiles, which can be dropped.

I think we just need to check on whether users are (usually) customizing ENTRYPOINT (or not,) and documenting for least astonishment.

zakame avatar Sep 14 '20 12:09 zakame

Hmm. Search all of GitHub's Perl repos for such usage? I guess docs would be needed in any case. I seriously doubt anyone is relying on the current behaviour of not doing signals right? ;-)

mohawk2 avatar Sep 15 '20 00:09 mohawk2

Is this now covered by the --init flag to docker run ?

sdt avatar Sep 15 '20 00:09 sdt

@sdt yes, though as https://github.com/Perl/docker-perl/issues/44#issuecomment-398443096 notes we can't rely on --init for running outside of Docker, such as in k8s.

@mohawk2 right, we've had a doc for this since https://github.com/docker-library/docs/pull/1550, which could do with an update (e.g. maybe mention https://github.com/openSUSE/catatonit as another alternative, or use sigtrap ... if handling from Perl natively.)

zakame avatar Sep 15 '20 04:09 zakame