Perfect-MySQL icon indicating copy to clipboard operation
Perfect-MySQL copied to clipboard

Fixed incorrect return value checks

Open saltzmanjoelh opened this issue 8 years ago • 3 comments

https://dev.mysql.com/doc/refman/5.7/en/mysql-commit.html https://dev.mysql.com/doc/refman/5.7/en/mysql-rollback.html

Return Values Zero for success. Nonzero if an error occurred.

saltzmanjoelh avatar Jul 06 '17 06:07 saltzmanjoelh

@saltzmanjoelh Thanks for the pull request, however, would you mind check out the latest version of this repo and do another PR to resolve the conflicts, if possible?

RockfordWei avatar Jan 18 '18 20:01 RockfordWei

okey dokey, should be good to go @RockfordWei

saltzmanjoelh avatar Jan 29 '18 21:01 saltzmanjoelh

Sorry FYI, may I also ask a test script for your PR, if possible, something like testTransactions() to prove your valuable work and help the end users to best understand this proposal.

Thank you very much!

RockfordWei avatar Jan 29 '18 21:01 RockfordWei