TedPermission icon indicating copy to clipboard operation
TedPermission copied to clipboard

Published 20 hours ago • verified publisher icon ParkSangGwon

Kotlin DSL

Open lutsenko-yuriy opened this issue 7 years ago • 3 comments

  • Adding Kotlin support to project
  • Building Kotlin DSL which in theory should make code more readable
  • Some changes in PermissionBuilder like turning String[] permissions into final List<String> permissions which should make code less error-prone
  • Some changes in ObjectUtils which also should make code less error-prone

lutsenko-yuriy avatar Mar 04 '18 22:03 lutsenko-yuriy

Because of there is no test code in this project, I'll run code and reply. Thanks

JSpiner avatar Mar 06 '18 06:03 JSpiner

@lutsenko-yuriy Sorry, Nowadays I start study kotlin language. When I finish study, I will review your code. Or If many other people approve this PR, I will approve too.

ParkSangGwon avatar May 24 '18 12:05 ParkSangGwon

@ParkSangGwon That's ok. There is actually some room for improvements so I marked this pull request as Work In Progress. Thank you for your reply anyway

lutsenko-yuriy avatar Jun 03 '18 13:06 lutsenko-yuriy