Paper
Paper copied to clipboard
Expand Instrument API
Trying out a new pattern. Instead of shoving tons of methods into Unsafe, this uses services to interact with nms from a non Craft- extended type.
Would be nice if the service interface wasn't public somehow (similar to PaperBrigadier) - the downside of that is mockbukkit etc would be forced to put their mock impl in the bukkit/paper package.
That's not super simple because of the craftbukkit package mismatch. If this were all in paper packages, it could work. But it can't be package-private because there is no equivalent bukkit package (unless we add this one thing to org.bukkit).
That's not super simple because of the
craftbukkitpackage mismatch. If this were all in paper packages, it could work. But it can't be package-private because there is no equivalent bukkit package (unless we add this one thing to org.bukkit).
I think a couple methods in unsafe is better in this case then, rather than the methods and an additional interface