Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Expand Instrument API

Open Machine-Maker opened this issue 2 years ago • 3 comments

Trying out a new pattern. Instead of shoving tons of methods into Unsafe, this uses services to interact with nms from a non Craft- extended type.

Machine-Maker avatar Nov 19 '22 20:11 Machine-Maker

Would be nice if the service interface wasn't public somehow (similar to PaperBrigadier) - the downside of that is mockbukkit etc would be forced to put their mock impl in the bukkit/paper package.

jpenilla avatar Nov 19 '22 20:11 jpenilla

That's not super simple because of the craftbukkit package mismatch. If this were all in paper packages, it could work. But it can't be package-private because there is no equivalent bukkit package (unless we add this one thing to org.bukkit).

Machine-Maker avatar Nov 20 '22 01:11 Machine-Maker

That's not super simple because of the craftbukkit package mismatch. If this were all in paper packages, it could work. But it can't be package-private because there is no equivalent bukkit package (unless we add this one thing to org.bukkit).

I think a couple methods in unsafe is better in this case then, rather than the methods and an additional interface

jpenilla avatar Nov 20 '22 17:11 jpenilla