Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add method for getting a sound's subtitle key

Open Machine-Maker opened this issue 3 years ago • 4 comments

Soooooo since the client uses one of the many resources it downloads for associated a sound with a subtitle key, the test makes a request to mojangs resources api. idk how good that is, maybe the test should be disabled most of the time or smth. But, it works. I also wrote a function that generates the big switch statement thats commented out of the test by default cause most of the time it doesnt need to be run.

Machine-Maker avatar Dec 31 '21 19:12 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 03 '22 22:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 31 '22 01:05 stale[bot]

Rebased for 1.19.2.

Currently, this uses the taskCache folder inside Paper-Server instead of the root one. Idk if that matters, it just threw me for a loop when I went looking for the downloaded json files earlier today.

Machine-Maker avatar Nov 19 '22 23:11 Machine-Maker

It shouldn't be a big deal since it's gitignored. Maybe try building and then changing a patch, reapplying patches and building again with --console=verbose to see if it reruns the task

jpenilla avatar Nov 19 '22 23:11 jpenilla