Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Ignore NBT limits when loaded not loaded from a block place

Open Machine-Maker opened this issue 4 years ago • 11 comments

Discovered this was an issue for datapacks that used lines on signs to store data, the 2048 char limit broke the shulker preview datapack. This just allows loading tile entity nbt to bypass those limits if its the result of a command.

There are probably more places that could use this, I just don't know what they are.

Machine-Maker avatar May 30 '21 00:05 Machine-Maker

Reworked it when I realized the default should be to allow anything except when placed down as an item.

Machine-Maker avatar May 30 '21 00:05 Machine-Maker

Rebased for 1.17.1

Machine-Maker avatar Aug 07 '21 00:08 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 22 '21 06:11 stale[bot]

Rebased for 1.18.1

Machine-Maker avatar Dec 22 '21 07:12 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 20 '22 08:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 24 '22 01:04 stale[bot]

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

stale[bot] avatar May 01 '22 16:05 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 02 '22 00:07 stale[bot]

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

stale[bot] avatar Jul 10 '22 00:07 stale[bot]

Rebased for 1.19

Machine-Maker avatar Jul 10 '22 19:07 Machine-Maker

I honestly think that these limits should be toned down, as most of them are outdated (doesn't apply to filtered text, etc) and in general don't make much sense anymore to have.

Owen1212055 avatar May 18 '23 13:05 Owen1212055

The issue this was created to address doesn't exist anymore as upstream removed their arbitrary limit on sign text length (2048). Can revisit if we want to make the banner pattern limit configurable.

Machine-Maker avatar Jul 17 '24 00:07 Machine-Maker