PaolaRuby

Results 119 comments of PaolaRuby

Feel free to make a PR for fix that Also you can link lines instead of `BackupCommand.php:67` https://github.com/spatie/laravel-backup/blob/994d10018aad578258ed6bf341361c3a532eb620/src/Commands/BackupCommand.php#L67 But maybe you config `report()` to send notification(Slack or mail) https://github.com/spatie/laravel-backup/blob/994d10018aad578258ed6bf341361c3a532eb620/src/Commands/BackupCommand.php#L64 https://github.com/ffeytons/laravel-backup/commit/e8148bca7013ffafee3165e190c9e6234eff6ac5

>Do you agree with this? Not the best, because when the exception is outside of the `try` on `BackupJob.php`, it never notified

>Looks like it'd be worth to refactor a bit the exception management Yes, it could be the best on this case

This is not a bug https://github.com/spatie/laravel-backup/blob/1aa4394e8dd619a2a2cbd480240148ace5f643f4/config/backup.php#L57 https://github.com/spatie/laravel-backup/issues/1368#issuecomment-959925953 https://github.com/spatie/laravel-backup/issues/1446#issuecomment-1013183295

Because it the best, not need to know why

@futzlarson it uses another laravel package for mysql dump, that package uses default laravel database configs, there is no way to send third party configs to that package as default...

>How could I solve this problem? Making a PR with the fix

> please email [[email protected]](mailto:[email protected]) directly instead of using the issue tracker.

Really sad, all the caffeinated packages gets abandoned @kaidesu @thekanbo ping :/