Pablo Castellano

Results 85 comments of Pablo Castellano

Hey @LefterisJP, I have just rebased this PR. It's much easier to review than it was initially after the smaller PRs already merged.

Hi @pascalalich. Binance broke their API and rotki v1.25.3 fixed it (https://github.com/rotki/rotki/issues/4781). Are you using the latest released version?

@kelsos Since you wrote most of the github action, wdyt about running all the tests everytime there are changes under the .github directory?

Ok! From your feedback I've removed the .github from the list of directories that trigger running backend tests. The issue I see here is that modifying the github actions will...

This is dupe of https://github.com/mattermost/focalboard/issues/166

After applying these two changes said by @anpbabaki I still get my logs flooded with "failed to get RI price for {region} {instancetype}"

Any chance to get this trivial PR merged?

@kavdev Sure, here are some examples: **Creating a customer object for a user that has signed up and updated his profile**. In this case the test checks that two webhook...

The proposed solution should be able to catch bugs like https://github.com/dj-stripe/dj-stripe/issues/1293 and https://github.com/dj-stripe/dj-stripe/commit/662c8fe8d21ced5325efd5c94695b493ea82ddf6

I can confirm the same for TaxRate model in 2.4.1 (worked in 2.4.0)