node-twitter-api-v2 icon indicating copy to clipboard operation
node-twitter-api-v2 copied to clipboard

Published 20 hours ago • verified publisher icon PLhery

[improvement] Eslint GitHub action

Open nolbuzanis opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe. There are some eslint errors that are present in the latest commit on master. Eslint is a good idea but it is not enforced at all.

Describe the solution you'd like I've used the husky package to run a git pre-commit hook which runs npm run lint. This was all code that is committed would follow the eslint rules (or would knowingly ignore them).

nolbuzanis avatar Apr 07 '22 03:04 nolbuzanis

Hi, Personally I prefer to see this as a GitHub action, git hooks are really intrusive.

alkihis avatar Apr 07 '22 05:04 alkihis