Michael Kliewe
Michael Kliewe
It depends on the version of ImageMagick of cause. It looks like "6.8.9-9" has a working implementation, but sometimes you additionally need to install "webp" or "cwebp" or "libwebp-dev" to...
If there is no return statement, the function returns "void", correct? If you store the return value to a variable, it's stored as "null". "void" as a return type is...
Oh, you are right! `$this->errorGeneric()` always throws an Exception. Maybe the function `errorGeneric()` should have a PHPDoc of `@throws HTMLPurifier_VarParserException` then phpstan might not report the missing return statement anymore....
If I set `@return string|null` the error in phpstan is gone, but I still get the error in PHPStorm "`Missing 'return' statement`":  If I set it to @return string|null|void...
I guess you are talking about a "Notice" which is new in PHP 8.0, that occurs if you access an undefined property in a class. You should be able to...
@davidearl If you don't declare properties, in PHP 8.x you get Notices, Warnings when reading. In >=8.2 you'll get Notices when writing to an undeclared property. In PHP 9 you'll...
CSS code is extracted and sent to CSSTidy, maybe it makes sense to do something similar for SVG? An "SVG sub-parser" or so?
Maybe a Filter which removes all HTML comments (which are not HTML conditionals) could be nice. I guess HTML comments with complete HTML tags in it could also fail in...
Maybe the regex of ExtractStyleBlocks can be improved, so that it doesn't match `` tags inside HTML comments... But that's not easy I guess 😄 Another possibility would be to...