GoogleAuthenticator icon indicating copy to clipboard operation
GoogleAuthenticator copied to clipboard

Published 20 hours ago • verified publisher icon PHPGangsta

there have a bug, resolved.

Open adotpeng opened this issue 7 years ago • 3 comments

getCode method return value is blank

adotpeng avatar Apr 12 '18 13:04 adotpeng

Hello,

can you please explain where the bug exactly is? Why does getCode() not return the correct value? It works since years. Maybe you changed my class and activated strict_types or so? That might fail, because str_pad() expects a string as first parameter, but the modulo-operation gives an int value. But that only happens if you changed my class/file, and activated strict_types for it. Or is there another problem with the code you are fixing?

Why did you introduce the variables $secretLen and $eightBitsLen, they are not needed I think. Can you please explain why you introduced them?

Thanks

PHPGangsta avatar Apr 12 '18 13:04 PHPGangsta

i am sorry, i used strict_types. thanks for your reminder.

adotpeng avatar Apr 12 '18 14:04 adotpeng

This PR should be closed. As far as I can see (and as per the above discussion) there is no issue here to fix, as strict_types is not enabled for this library.

MarkMaldaba avatar Mar 12 '21 12:03 MarkMaldaba