core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon OsmSharp

Support if-unused attribute in OsmChange.

Open blackboxlogic opened this issue 6 years ago • 2 comments

I see there is a test to deserialize a a change file where the Delete element has an if-unused attribute, but

  • After deserialization, there is no record that the delete was 'if-unused'
  • There is no way to generate XML that has 'if-unused'

A description of the feature's purpose can be found here

blackboxlogic avatar Jul 31 '19 16:07 blackboxlogic

There is no clear path for fixing this. If I got guidance, I can make a pull request. The problem is that Deletes are stored as an OsmGeo[] in OsmSharp.Changesets.OsmChange.Delete so there is no room for any more data on the Delete object. It could live on the OsmChange object though. Thoughts?

blackboxlogic avatar Aug 05 '19 19:08 blackboxlogic

I'm assigning this to myself and have a look.

An idea: We could introduce an extra object specifically for delete operations that has an implicit cast from OsmGeo for the default cases.

xivk avatar Aug 06 '19 10:08 xivk