openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Use hardhat-exposed to reduce the need for mocks

Open Amxx opened this issue 3 years ago • 3 comments

PR Checklist

  • [x] Tests

Amxx avatar Aug 31 '22 21:08 Amxx

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

socket-security[bot] avatar Sep 01 '22 17:09 socket-security[bot]

Inspected the above postinstall scripts and they're safe.

frangio avatar Sep 01 '22 19:09 frangio

I would like us to review the "mock" name and switch to a new one. Maybe we can just rename everything to Test instead of Mock.

See https://github.com/OpenZeppelin/openzeppelin-contracts/issues/1320

frangio avatar Sep 15 '22 16:09 frangio

FYI, just don't underestimate this breaking change - it will break many of my unit tests since I pull some of your (here deleted) mocks via submodules. So once you merge this PR to master and I update the submodules it will break (i.e. before you make a new release). Just wanted to quickly make you aware of this.

pcaversaccio avatar Nov 16 '22 10:11 pcaversaccio

@pcaversaccio Thanks for the heads up. We don't guarantee stability of mocks at all. You should try to remove that dependency if possible.

frangio avatar Nov 16 '22 16:11 frangio

LGTM

Amxx avatar Jan 03 '23 14:01 Amxx

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

GitPOAP: 2023 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

gitpoap-bot[bot] avatar Jan 03 '23 14:01 gitpoap-bot[bot]