OpenHPL icon indicating copy to clipboard operation
OpenHPL copied to clipboard

use of "abstract" classes

Open dietmarw opened this issue 2 years ago • 2 comments

@boerrebj: Abstract classes (partial classes in Modelica terminology) are useful for collecting common parts of multiple detailed models. As an example,

  • AbstractPipe basis class for both rigid water column pipe as well as elastic water pipe
  • AbstractValve basis class for different types of valves
  • AbstractTurbine basis class for different turbine types

dietmarw avatar Jun 19 '23 10:06 dietmarw

I would probably tend to call those:

  • BasePipe
  • BaseValve
  • BaseTurbine

dietmarw avatar Jun 19 '23 10:06 dietmarw

One possible alternative could be: AbstractTwoPortElement ->

  • AbstractPipe
  • AbstractSingularLossElement (typical for trash racks, contractions/expansions etc.)
  • AbstractControlledElement (typical for both gates and valves)
  • AbstractTurbine

boerrebj avatar Jun 19 '23 12:06 boerrebj