Chronicle-Wire
Chronicle-Wire copied to clipboard
OpenHFT
Update all test to work with YAML wire
Update all test to work with YAML wire by using system property wire.testAsYaml, then remove TextWrire, first mark deprecated
First phase would be #411 to remove a separate Text wire writer, then we should consider if removing Text wire parser is feasible as well.
@peter-lawrey wants to remove or rather deprecate TextWire, so can you close the ticket once we get to 100%, best to list the test which still use text wire.
I will check which tests only use TEXT wire but not YAML. But thing is, a lot of test cases are actually covered by tests outside Wire (such as Map, Queue tests which take TEXT as input or output) and those only test TEXT wire
So we will know how much stuff is broken only when we switch. I will do that to my TextWire writer unifications and see if anything breaks.
TEXT wire still has to be tested since it is actively used. Moreover I'm not sure if we can deprecate TextWire completely since we may be reliant on it for reading existing text documents produced by TextWire which may not be proper YAML.
YAML wire does not support deserialization of true as 1 and false as 0 - do we need it?
TextBinaryWireTest is the relevant test
InvalidYamWithCommonMistakesTest failures were ignored because they test for non-compliant parsing and the goal of YAML is to be compliant