lightning icon indicating copy to clipboard operation
lightning copied to clipboard

Handle simultaneous editors working in same workflow

Open taylordowns2000 opened this issue 2 years ago • 3 comments

All sorts of problems can still be caused by having two users make changes to the same workflow. (We've made this low priority now since we don't allow multiple users per project except on special request before public release.)

  • Notify/warn when another user is viewing or editing?
  • Use Phoenix Presence?

MVP implementation

Warning that this might not be a good MVP, as it could limit us fairly significantly if we later want "pointer tracking" or "cursor tracking" using cool stuff like CRDTs.

  1. Use Phoenix Presence to display a warning when there is another editor.
  2. On "Save" display a warning that you may overwrite a new change, ask user if they want to continue.
  • [ ] #1949

Design here: https://www.figma.com/file/4hGWdO4sajnjcOwE81j8BK/App-(new)?type=design&node-id=2477-4493&mode=design&t=Ha7Ifoa1WICUVpmp-0

taylordowns2000 avatar Apr 01 '23 14:04 taylordowns2000

I am proposing a temporary fix that tells the user that someone is actively editing on the canvas. We can go further to allow the user but they will only be able to proceed in view/read only mode.

Image

christad92 avatar Mar 26 '24 02:03 christad92

This is great. I'd upvote strong here as we now allow users to add collaborators via the UI.

taylordowns2000 avatar Apr 19 '24 13:04 taylordowns2000

Sentry Issue: LIGHTNING-CC

sentry-io[bot] avatar May 14 '24 16:05 sentry-io[bot]