openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[Spring] Resolve default value issue with Lombok Builder

Open levitin opened this issue 1 year ago • 5 comments

Resolving #18689

levitin avatar May 16 '24 16:05 levitin

thanks for the PR

can you please update the samples as well as requested in step 3 of the PR checklist?

cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

wing328 avatar May 21 '24 07:05 wing328

Hi @levitin, thanks for the PR!

Unfortunately, the updated java-camel sample doesn't compile. Running maven compile in samples/server/petstore/java-camel/ results in the error message "package lombok.Builder does not exist". Please fix this.

I will create a PR to have the java-camel sample automatically tested as part of the PR checks in the future.

martin-mfg avatar Jul 04 '24 07:07 martin-mfg

Can this get merged now, or what are we missing here? @levitin @wing328

rethab avatar Oct 11 '24 13:10 rethab

Can this get merged now, or what are we missing here? @levitin @wing328

As a replacement for this PR I created #19855 and resolved there the problem I mentioned in my comment above.

martin-mfg avatar Oct 13 '24 16:10 martin-mfg

Awesome, @martin-mfg . Anything I can help with to get it merged?

rethab avatar Oct 16 '24 14:10 rethab