OneSignal-Xamarin-SDK icon indicating copy to clipboard operation
OneSignal-Xamarin-SDK copied to clipboard

Native to abstract extensions

Open ArgusMagnus opened this issue 8 years ago • 3 comments

I propose to make the methods used to convert the native variants of OSNotification, OSNotificationOpenedResult, etc. to their abstract counterparts available as extension methods.

I needed this functionality when implementing an NotificationExtenderService for Android in a Xamarin.Forms project. I think the proposed changed would allow for better discoverability of this functionality.

This change is Reviewable

ArgusMagnus avatar Apr 04 '18 12:04 ArgusMagnus

@ArgusMagnus I'll take a look when I am available, in the mean time can you fix the merge conflict noted below?

jkasten2 avatar Apr 06 '18 20:04 jkasten2

Yes, I'll do it once im free

ArgusMagnus avatar Apr 09 '18 06:04 ArgusMagnus

@ArgusMagnus , BUMP

rgomezp avatar Apr 30 '19 23:04 rgomezp