fanalysis icon indicating copy to clipboard operation
fanalysis copied to clipboard

`.as_matrix()` removed from pandas now is `.values()`

Open Carreau opened this issue 5 years ago • 3 comments

Hi,

It looks like as_matrix() has been deprecated since pandas 0.23 and finally been removed.

Would you be open to a pull request that update the code, and if so will you publish an updated version on PyPI ?

Thanks.

Carreau avatar Apr 23 '20 16:04 Carreau

Hi Carreau,

You can replace as_matrix() by .values() and keep the all code

fcarpentey75012 avatar Jun 04 '20 08:06 fcarpentey75012

You can replace as_matrix() by .values() and keep the all code

Yes, that's what my title say, but the code here does use .as_matrix() in the test and example. I'm asking if it's ok to send a PR to update.

Carreau avatar Jun 04 '20 21:06 Carreau

Yes, i'm sorry. I didn't read the title..

fcarpentey75012 avatar Jun 05 '20 11:06 fcarpentey75012