compress-tools-rs
compress-tools-rs copied to clipboard
OSSystems
feat: add support to iterator over encrypted zip
Adding support to iterate over encrypted archives zip.
ONLY SUPPORTS ZIP ( libarchive limitation ) libarchive documentation -> readme.md
Note: I just implemented it in the iterator, because I don't have time to implement it in the rest, but the idea is the same.
Support for (RAR) It doesn't support encrypted '.rar' files, because it is a limitation of the libarchive itself, I searched in every way and even after implementing the correction I tried to iterate over a '.rar' file, but I don't get an error and it doesn't display any content either.
the only solution I saw that works is a binding made in unrar.c, but for that I would have to restructure the entire library to implement only this use case for '.rar' file
I didn't understand either, I realized that when I run the "cargo test" it breaks in my test, but if I run my test individually it works, it's like I'm mocking some function I'm using..
And regarding the fixes, I'll try to do it tomorrow, all the points you commented make total sense.
If it fails in your machine, it might be a race of memory corruption. Check in cargo-valgrind.
@hivexdev progress. The failing tests are fixed. The Windows failure is unrelated.
can the passphrase be non ascii , will this work for decrypting a password protectd zip?
Pull Request Test Coverage Report for Build 5148429169
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+1.1%) to 85.049%
| Totals | |
|---|---|
| Change from base Build 5093406152: | 1.1% |
| Covered Lines: | 347 |
| Relevant Lines: | 408 |
💛 - Coveralls
Pull Request Test Coverage Report for Build 5148429169
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+1.1%) to 85.049%
| Totals | |
|---|---|
| Change from base Build 5093406152: | 1.1% |
| Covered Lines: | 347 |
| Relevant Lines: | 408 |