osmcha-frontend

osmcha-frontend copied to clipboard

I'm submitting a bug report

Brief Description

If you remove tags from an area because you create a multipolygon with these tags, osmcha flags it as "invalid tag modification"

What is the motivation / use case for this action?

There are multiple possible reasons for creating multipolygons from area, usually because you have to split a way, add a hole or separate perimeter from the area

What is the current behaviour, (attach relevant screenshots) ?

flags it as "invalid tag modification"

What is the expected behaviour ?

does not flag it

When does this occur ?

always in this context (see above)

How do we replicate the issue ?

Please tell us about your environment:

Other Information / context:

Same exact issue when you remove tags from a node, and incorporate that node is a closed way (which has the tags from the node). For example, converting a node address into a building. See Node 367794721 in Change 86292360.

And I would say the same fix should be applied to the warning "Deleted a wikidata/wikipedia tag" when that whole element (and its tags) were being merged into something else. See Node 367794682 in Change 86292360.

I can confirm this is still the case

Base bug: https://github.com/mapbox/osm-compare/issues/147 Possibly dead PR to fix this: https://github.com/mapbox/osm-compare/pull/149