grass icon indicating copy to clipboard operation
grass copied to clipboard

Published 20 hours ago • verified publisher icon OSGeo

v.out.ogr: Fix exporting vector layers from a location whose CRS has no EPSG code

Open ldesousa opened this issue 1 year ago • 6 comments

This PR addresses issue #2187: the v.out.ogr module fails to export vector layers from a location whose CRS does not have an entry in the EPSG registry. The root cause is the inadequate discarding of the Ogr_projection object in vector/v.out.ogr/main.c. In addition a new test is provided for this module verifying the correct creation of layers from such locations. This test fails with the current master branch (release 8.3).

This PR is incremental on PR #3848. Please merge that one before merging this one.

ldesousa avatar Jun 17 '24 13:06 ldesousa

@ldesousa Can you please:

  1. update the description to include what this is fixing and how and when it is failing (I suppose that the new test is failing without the change and passing with it, correct?)
  2. shorten the title

wenzeslaus avatar Aug 01 '24 14:08 wenzeslaus

Once it will be ready for merging, the title isn't clear to me what it does (an issue number is great for PR descriptions, but less as a changelog entry and PR titles). Our PR titles are changelog entries, and are what we will see in the code in for the rest of the lifetime of the project

echoix avatar Sep 03 '24 22:09 echoix

Once it will be ready for merging, the title isn't clear to me what it does (an issue number is great for PR descriptions, but less as a changelog entry and PR titles). Our PR titles are changelog entries, and are what we will see in the code in for the rest of the lifetime of the project

@echoix I already lengthened/shortened the title a few times. Could you confer with @wenzeslaus which kind of title you wish for this PR?

ldesousa avatar Sep 06 '24 16:09 ldesousa

@rouault I already lengthened/shortened the title a few times. Could you confer with @wenzeslaus which kind of title you wish for this PR?

maybe "v.out.ogr: fix exporting vector layers from a location whose CRS has no EPSG code" ?

rouault avatar Sep 06 '24 17:09 rouault

@rouault Sorry, wrong tag. Let's wait for all the internal GRASS procedures to be ready. Then I will ask for your review again. Thanks.

ldesousa avatar Sep 06 '24 17:09 ldesousa

@rouault I already lengthened/shortened the title a few times. Could you confer with @wenzeslaus which kind of title you wish for this PR?

maybe "v.out.ogr: fix exporting vector layers from a location whose CRS has no EPSG code" ?

I actually find that great, I can't reword it any better way that doesn't end up sounding weird

echoix avatar Sep 07 '24 01:09 echoix