grass icon indicating copy to clipboard operation
grass copied to clipboard

Published 20 hours ago • verified publisher icon OSGeo

fix g.list on msvc using pcre

Open rkanavath opened this issue 5 years ago • 3 comments

To be merged after https://github.com/OSGeo/grass/pull/357

g.list uses regex.h which is not available on MSVC. This PR fixes g.list by using pcre library on windows and use regex.h on other platforms.

This is Work in progress. Need to test the functionality of pcre v. regex

rkanavath avatar Feb 18 '20 00:02 rkanavath

The different PRs would add the same files, e.g. CMakeLists.txt in this PR and in #355, #354 and others. Please avoid the addition of the same files or identical changes in different PRs.

metzm avatar Feb 24 '20 21:02 metzm

@metzm, I don't know how to do that when splitting a big PR. IF #357 is merged that I can rebase this current branch with master and will only have changes related to prce. But then it has to wait for other PR.

rkanavath avatar Feb 26 '20 08:02 rkanavath

I don't have a good suggestion on how to do it in this case because you need the CMake PR changes to make all the other things work. The only way I see is having the CMake changes in the source code uncommitted.

However, given the current state, it might be sufficient to resolve this only after the CMake PR is merged. The CMake support might not be finished, but the PR is close to something which could be merged.

wenzeslaus avatar Feb 26 '20 14:02 wenzeslaus