ondemand

ondemand copied to clipboard

Thanks, I think this is ready. One thing that I'm going to make a ticket on now is how the config uses group to create sub-categories & dividers. Maybe that should be title?

I can't tell, but there's something that's not intuitive about this. I just mean there may be some slight tweak here that'll make it easier to document and understand.

Take this as an example. Here we're using group and title both as separators. Sometimes within the navigation item and sometimes outside of it.

nav_bar
 - title: "Apps Menu"
   links:
     - "sys/bc_osc_rstudio/*"
     - apps: [ "sys/bc_osc_jupyter" ]
     - group: "SubApp"
       apps: [ "sys/bc_desktop" ]
     - group: "Core Apps"
     - apps: [ "sys/bc_desktop" ]
     - group: "RStudio"
     - apps: [ "sys/bc_osc_rstudio/*" ]
     - group: "Profiles"
     - title: "Team 1"
       profile: "team1"
     - title: "Team 2"
       profile: "team2"

Originally posted by johrstrom in https://github.com/OSC/ondemand/pull/2270#pullrequestreview-1099712332

┆Issue is synchronized with this Asana task by Unito

Note that I may actually just be confused on this and the example given in the PR changed over time when I didn't.

It could also be that group is perfectly applicable here and we close this as there's nothing to do. In any case, I think it'll become clear as we use and start to document the feature whether this is the best fit.

Writing the documentation helped clear this up. group is for group/submenu seperators where title is the title of the list item.