web-apps icon indicating copy to clipboard operation
web-apps copied to clipboard

Skip unused grunt package not available on FreeBSD.

Open Teetoow opened this issue 5 years ago • 4 comments

Remove the use of grunt-mocha package (it seems not be used in production). This package needs phantomjs which seems to be an unmaintained package. Since it is no more available under FreeBSD I removed this line. There is no consequences on the OnlyOffice DocumentServer code.

Teetoow avatar Aug 25 '20 12:08 Teetoow

I asked our devs and they said that currently we do not use grunt-mocha but planning to add some more test in future, so we don't like idea of complete removal

Could this packaged be OS-dependent and do not installed and called on FreeBSD?

ShockwaveNN avatar Aug 25 '20 13:08 ShockwaveNN

I asked our devs and they said that currently we do not use grunt-mocha but planning to add some more test in future, so we don't like idea of complete removal

Maybe it is possible to use grunt-mocha by developers during development and don't try to install it on production environment since it is only a package to make some tests?

Could this packaged be OS-dependent and do not installed and called on FreeBSD?

First thing is that phantonJS seems to be an unmaintained package (that's why it is deprecated): npm WARN deprecated [email protected]: this package is now deprecated

Next it seems that this version depends on libraries which are no more available under FreeBSD:

> [email protected] install /tt/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Unexpected platform or architecture: freebsd/x64
It seems there is no binary available for your platform/architecture
Try to install PhantomJS globally

I don't know what to say about that.. Except that it's a package which could be useful for developers and not for end users. Since it is not available on all platforms (at least FreeBSD) it might be interested to think about not installing it on production?

Teetoow avatar Aug 25 '20 16:08 Teetoow

Thanks for pointing out, we did some research and moved some packages to devDependencies, so whey should not be installed on Production environment

https://github.com/ONLYOFFICE/web-apps/commit/74a44dce21bc345bd9035284d9e4361cfd07bdd0

ShockwaveNN avatar Aug 26 '20 08:08 ShockwaveNN

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 22 '21 08:03 CLAassistant

mocha is in dev dependencies now, and phantomjs close it

maxkadushkin avatar Sep 06 '23 17:09 maxkadushkin