core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon OCR-D

Add check for pull requests (GitHub action)

Open stweil opened this issue 3 years ago • 3 comments

Signed-off-by: Stefan Weil [email protected]

stweil avatar Jul 16 '22 07:07 stweil

See this example of a bad pull request which triggers a CI failure.

stweil avatar Jul 16 '22 07:07 stweil

@kba, please merge.

stweil avatar Apr 15 '24 07:04 stweil

This new GitHub action currently checks pull requests for whitespace issues. It can be extended to

  • check for typos
  • check for author names without valid name and e-mail
  • check for valid signature
  • more?

What formal checks for pull requests should be added?

The action code includes code from https://github.com/JensDll/should-run. That is a GitHub action which could be used to select the CI tests depending on the changes made by a pull request. For example the pull request here does not change code, so running all CI tests is not necessary and currently wasting resources.

stweil avatar Apr 15 '24 08:04 stweil