purl.obolibrary.org icon indicating copy to clipboard operation
purl.obolibrary.org copied to clipboard

Add d2p and g2p files here?

Open drseb opened this issue 5 years ago • 8 comments

@matentzn or anybody else: do you think I can add the links to d2p and g2p files (something similar to go-gene-association files) at this place: https://github.com/OBOFoundry/purl.obolibrary.org/blob/ec0618b76408d058e26d8704661d2cb1af6dff48/config/hp.yml#L12

thanks for any help

drseb avatar Aug 25 '20 17:08 drseb

This is a policy question; I would say yes, but better ask @cmungall. Note that when something is added to the yaml file it can never be removed.

matentzn avatar Aug 25 '20 17:08 matentzn

So the question is: can we add non ontology artefacts logically belonging to our ontology as primary products in the yaml file like:

products:
- hp.owl: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/master/hp.owl
- hp.obo: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/master/hp.obo
- hp.json: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/master/hp.json
- hpao-d2p.tsv: uri

matentzn avatar Aug 25 '20 17:08 matentzn

If you wanted to host the files on github, you of course dont need to do anything.. you could place them in a folder annotations and then the purl http://purl.obolibrary.org/obo/hp/annotations/hpao-d2p.tsv would work even without further configuration (because of the generic fallthrough).

matentzn avatar Aug 25 '20 17:08 matentzn

Please use a subdirectory or something, not products.

jamesaoverton avatar Aug 25 '20 17:08 jamesaoverton

I agree, I guess the question was posed because of a need to redirect somewhere outside the fall through. But even that should be possible right?

You could do:

entries:
- prefix: /hpoa-d2p.tsv
  replacement: http://compbio.charite.de/hudson/job/hpo.ontology.uberpheno/lastStableBuild/artifact/data/out/hpoa.tsv

- prefix: /releases/
  replacement: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/v

matentzn avatar Aug 25 '20 17:08 matentzn

Yes you can have multiple prefix entries. They are mtached in order, so just be careful.

But for a single file I would use exact not prefix, so exact: /hpoa-d2p.tsv

jamesaoverton avatar Aug 25 '20 18:08 jamesaoverton

Thanks @jamesaoverton!

@drseb You want to give this a shot yourself? I will review it; or I can do it for you if you tell me what you want to link.

matentzn avatar Aug 25 '20 18:08 matentzn

@matentzn I will DM you regarding a call to implement this asap

drseb avatar Aug 26 '20 19:08 drseb