Overlay-Specification icon indicating copy to clipboard operation
Overlay-Specification copied to clipboard

Published 20 hours ago • verified publisher icon OAI

Example showing setting default response

Open darrelmiller opened this issue 3 years ago • 4 comments

darrelmiller avatar Mar 10 '22 03:03 darrelmiller

Your commits didn't get signed this time for some reason, but yeah this would be super handy!

jlk avatar Jun 27 '22 19:06 jlk

@jlk I don't usually sign my commits. The license in the repo is authoritative when it comes to IPR.

@lornajane Do you think this would be a useful addition to Overlays?

darrelmiller avatar Jan 06 '24 14:01 darrelmiller

Without a pull request description, this took me a while to understand. What we're saying is that we should add these fields, conditional on them not being there already? So don't update, just add if you can. I can see some use cases, but I'm not sure "default" is the right naming for this behaviour.

In an attempt to be constructive with naming, how about add, with wording that makes it clear it will fail if the thing is there already? Or fallback - something to put in if a gap is found?

lornajane avatar Jan 10 '24 18:01 lornajane

See also #32 where we have commandeered the add syntax to mean something else. I'm still not sure what this operation should be called.

lornajane avatar May 06 '24 17:05 lornajane