novatec-service-dependency-graph-panel

novatec-service-dependency-graph-panel copied to clipboard

Describe the bug The "Namespace Delimiter" field is ignored, always using "." as namespace delimiter.

To Reproduce

• Install SDG panel in Grafana using the provided release bundle "novatec-sdg-panel-4.1.1-release.zip" (uncompress zip and copy novatec-sdg-panel folder into C:\Grafana\data\plugins folder).

• Restart Grafana and check it is properly listed and loaded in Grafana / Plugins / Service Dependency Graph

• Create a dashboard with an SDG panel, add a query for your data with 'FORMAT AS: Table', specify column names for the desired fields in "Connection Mapping" and "Data Mapping". So far so good, the graph shows nodes and connections properly.

• Specify the column name to use for "Namespace Column".

• Enter "_" as the "Namespace Delimiter" string (despite the field placeholder says "Enter column name...").

• The graph will still use "." as namespace delimiter, not honoring the entered value. This leads to an incorrect / too high number of layers. Example:

VPNCUSTOMERNAME_PEER111.111.111.111_PEER222.222.222.222 --> 7 layers:

• VPNCUSTOMERNAME_PEER111
• 111
• 111
• 111_PEER222
• 222
• 222
• 222

Expected behavior

• The graph uses the entered value for "Namespace Delimiter" as namespace separator. Example:

VPNCUSTOMERNAME_PEER111.111.111.111_PEER222.222.222.222 --> 3 layers:

• VPNCUSTOMERNAME
• PEER111.111.111.111
• PEER222.222.222.222

Screenshots (sorry, no screenshot of the panel due to containing sensitive information)

Your Setup:

• OS Grafana is running on: Windows Server 2019 Datacenter
• OS & Browser from which Grafana is accessed: Windows 11, Firefox 122
• Plugin-Version: 4.1.1-release (displays as 4.0.3 in Grafana / Plugins, but this is a different issue)
• Grafana-Version: v8.3.6
• Datasource & Version: Custom data from InfluxDB table

Additional context Inspecting the code, it seems that both "nameSpaceDelimiter" and "namespaceDelimiter" from the dataMapping structure are referred to. My proposal would be to use "namespaceDelimiter" in all places, in consonance with the "Namespace Delimiter" caption and because namespace is a single word, like Firefox or nonetheless. :)

Thank you! Jose