nixos-search

nixos-search copied to clipboard

Removes some dead code, including the unimplemented --elastic-user, --elastic-pw and --gc flags. Builds and tests with no warnings.

--gc is used though You can (could?) run the import on a fresh store which the gc flag would clean up after completion. I dont know if that is still useful to anyone though and could probably be implemented by just passing extra nix arguments

for the elastic-pw/user one I wonder if it would be better to implement these rather than remove them and use those flags rather than the url encoded authentication

--gc is used though You can (could?) run the import on a fresh store which the gc flag would clean up after completion. I dont know if that is still useful to anyone though and could probably be implemented by just passing extra nix arguments

It's not used. The run_gc function is never called. So I think it's safe to assume it's not useful to anyone :)

for the elastic-pw/user one I wonder if it would be better to implement these rather than remove them and use those flags rather than the url encoded authentication

Sure, we can do that in a follow-up PR, I'm just commenting them out for now.

I agree in both points

@ysndr could you approve please?

Thanks