nix icon indicating copy to clipboard operation
nix copied to clipboard

`ValidPathInfo` JSON format should use `null` not omit field

Open Ericson2314 opened this issue 1 year ago • 2 comments

Motivation

Context

Blocked on #9994, tests will fail until this

A little progress on #10311

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Ericson2314 avatar Feb 12 '24 15:02 Ericson2314

Discussed during the Nix maintainers meeting on 2024-02-26. Idea approved, but :

  • Should be mentioned in the release notes
  • Should be reflected in the json guidelines policy
  • @edolstra: Potentially breaking change, although probably not a big one

    • Also only happens in the new command-line
  • @thufschmitt: Do we care about having these null fields?

    • @roberth: Have a slightly different semantics, potentially interesting to distinguish
  • Idea approved

  • Should be mentioned in the release notes

  • Should be reflected in the json guidelines policy

thufschmitt avatar Feb 29 '24 06:02 thufschmitt

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-02-28-nix-team-meeting-129/40499/1

nixos-discourse avatar Feb 29 '24 07:02 nixos-discourse

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-06-03-nix-team-meeting-minutes-149/46582/1

nixos-discourse avatar Jun 06 '24 08:06 nixos-discourse