scripts/install.in: add riscv64 support to installer

Open jdek opened this issue 1 year ago • 4 comments

Motivation

The artifacts are already built and hosted, the install script just needs to be taught about riscv64.

Context

Making this change manually to the install script the Nix installation was able to succeed.

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

May 30 '24 13:05 jdek

I believe you'll also need to add riscv64 here: https://github.com/NixOS/nix/blob/ef5c846e257e1e284ad47ed6be4308d190fe6531/maintainers/upload-release.pl#L161-L165

May 30 '24 17:05 cole-h

@cole-h wouldn't that require a native riscv64 builder? the cross-compiled one is already downloaded:

https://github.com/NixOS/nix/blob/ef5c846e257e1e284ad47ed6be4308d190fe6531/maintainers/upload-release.pl#L174-L177

Though this should probably be hooked up to the cross-compiled store path for riscv64 here too:

https://github.com/NixOS/nix/blob/ef5c846e257e1e284ad47ed6be4308d190fe6531/maintainers/upload-release.pl#L240-L248

May 30 '24 18:05 jdek

Oh oops you're right, I meant to point at the fallback-paths.nix writing. Not sure why I decided the place I pointed to was the right place :sweat_smile:

May 30 '24 18:05 cole-h

@cole-h something like 73f9afd, I presume. I'm looking at https://hydra.nixos.org/build/260037794 for reference.

May 30 '24 18:05 jdek

Merging this with the caveat that it's best-effort (since we're not actually testing whether it works, only cross-building) and may be disabled if it breaks and blocks the release (since none of the maintainers are really capable of fixing riscv64 issues).