mobile-nixos

mobile-nixos copied to clipboard

I was wondering why there is so much space before the first partition for PinePhone and then I noticed this piece of code: https://github.com/NixOS/mobile-nixos/blob/3fa21329c44e8fa920108b64e16d2c41e1d7af52/modules/hardware-allwinner.nix#L8-L11

It reserves 8 MB plus 2 MB but bs=1024 seek=8 should be 8 kB instead of 8 MB, right? So maybe 2 MB or 4 MB in total: 8 kB before U-Boot SPL, at most 32 kB for SPL, ~500 kB for U-Boot, plus some headroom?

The Allwinner stuff needs to be re-done, I need to get my ducks in a row so they can domino on each other :).

I made some work in another project (unreleased), which I need to fall over another project (Tow-Boot), which I then need to fall onto this project to profit from. These changes will fix some of these kind of oversights.

Thanks for the issue, I would recommend not trying to fix it if only because that work would end up being obsoleted by overarching changes across multiple projects that are upcoming :)

At worst, for now, a few mebibytes are lost. I don't think many will mourn those mebibytes at the moment.

At worst, for now, a few mebibytes are lost. I don't think many will mourn those mebibytes at the moment.

Yes, I agree. We are writing our own partition script for PinePhone and we decided to keep it at 10 MB for exactly that reason :-D

Should we close this as "wontfix"? It will be fixed but we probably don't need this issue to track that.

This issue can stay open for reference for other individuals.

I will probably forget to close it once the partitioning is re-done for Allwinner. If you notice me forigetting it in the future you can close I guess :)

This now has been obsoleted by now well-known Tow-Boot stuff.