hydra icon indicating copy to clipboard operation
hydra copied to clipboard

JobsetInputAlts: Drop, storing the input's value directly in the Input table

Open grahamc opened this issue 3 years ago • 2 comments

This most certainly breaks the API(s), and potentially other things. We may want to add compatibility shims to the API.

I haven't tried using the UI manually, though the tests do pass. Also, I haven't tried writing a migration for this.

Another thing to consider is this will actually cause data loss for older instances. Hydra's newest jobsetevals record with a non-zero altNr is from October of 2017. I'm not sure what we should do about this: this is a pretty nice cleanup, and enables quite a lot more. However, I'm not eager to delete user's data.

grahamc avatar Feb 08 '22 04:02 grahamc

I'm going to post about this on the Hydra section of Discourse.

grahamc avatar Feb 08 '22 17:02 grahamc

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dropping-jobsetinputalts/17584/1

nixos-discourse avatar Feb 08 '22 17:02 nixos-discourse