monaco-vscode-textmate-theme-converter icon indicating copy to clipboard operation
monaco-vscode-textmate-theme-converter copied to clipboard

Published 20 hours ago • verified publisher icon Nishkalkashyap

VSCode theme `include` field

Open wkordalski opened this issue 3 years ago • 1 comments

In VSCode themes can "extend" other themes. It is done by include field in the extending theme.

monaco-vscode-texmate-theme-converter ignores this field. In case of convertTheme there is no other possibility (extended theme file path is relative to extending theme file path, and we do not know path of extending theme file path — we only know its parsed content). But in case of convertThemeFromFilePath and convertThemeFromDir we are able to handle the include field.

We should handle include field, or at least warn (in docs/README/etc.) that include field should be handled by the user of the library.

wkordalski avatar Feb 21 '22 18:02 wkordalski

Facing the same problem

sidwebworks avatar Jun 11 '22 19:06 sidwebworks