react-native-web-refresh-control icon indicating copy to clipboard operation
react-native-web-refresh-control copied to clipboard
verified publisher icon NiciusB

Aggressive patchFlatListProps

Open yangm97 opened this issue 4 years ago • 2 comments

When props.refreshing is undefined refreshControl shouldn't be be injected.

Right now patchFlatListProps changes the behavior of FlatLists which aren't supposed to have a refreshControl. It also causes some type warnings to be thrown in development.

https://snack.expo.dev/wcIw8L47u

yangm97 avatar Sep 11 '21 03:09 yangm97

Also breaks horizontal FlatLists https://snack.expo.dev/x_4Fv3WDC

yangm97 avatar Sep 11 '21 03:09 yangm97

You're right. I will fix it ASAP. It should only inject when onRefresh is defined, as per the FlatList docs

NiciusB avatar Sep 11 '21 14:09 NiciusB