LAVFilters icon indicating copy to clipboard operation
LAVFilters copied to clipboard

Published 20 hours ago • verified publisher icon Nevcairiel

Add limited support for AAC 22.2

Open kasper93 opened this issue 3 years ago • 4 comments
trafficstars

This changes input decode mask to uint64_t so we can feed that to downmixing. Output is still DWORD as no output > 8 is allowed anyway. Mostly focused on AAC 22.2 files to let them play, even if only downmixed to "saner" output.

kasper93 avatar Mar 01 '22 22:03 kasper93

Can you link to such a sample for testing?

Nevcairiel avatar Mar 02 '22 07:03 Nevcairiel

24ch.zip

kasper93 avatar Mar 02 '22 13:03 kasper93

@kasper93 Apparently now it support up to 64 channel, is this PR still needed?

ale5000-git avatar Apr 28 '22 12:04 ale5000-git

The sanity check is changed, but still channel mask, will be destroyed when truncating to DWORD.

kasper93 avatar Apr 28 '22 12:04 kasper93

Its been a bit slow going because I planned to get rid of the single-integer channel mask internally entirely, and swap to the new AVChannelLayout structure internally in LAV Audio as well. With ffmpeg in LAV finally being updated i'll hopefully manage to re-work this soon.

Nevcairiel avatar Aug 04 '22 09:08 Nevcairiel

Should be implemented in 2461adb9fd63b1c389ceee8ea23e047a39d1eb3. Instead of forcing mixing to be enabled, LAV will now automatically offer a secondary downmixed media type, and use it when needed. This allows audio renderers to also receive the full undownmixed variant, if they support it.

Nevcairiel avatar Aug 23 '22 11:08 Nevcairiel