hubcommander icon indicating copy to clipboard operation
hubcommander copied to clipboard

Add develop tag to docker hub image

Open yaron-idan opened this issue 8 years ago • 4 comments

Right now docker hub only allows pulling releases of hubcommander. Could be very handy to be able to pull the develop branch directly, instead of waiting for a new release. Right now if I want to deploy the develop branch I have to build the image myself, which is pretty easy thanks to the great build-docker.sh script, but having develop available for me directly from docker hub would be nice. Thanks, Yaron.

yaron-idan avatar Dec 18 '17 08:12 yaron-idan

Agree -- this would be nice to have.

mikegrima avatar Dec 19 '17 21:12 mikegrima

Hey @mikegrima, could I please get feedback for the PR I've opened (#85)? Thanks.

yaron-idan avatar Dec 28 '17 13:12 yaron-idan

Merged it in. Thank you for the PR!

I think the last main portion is to modify: https://github.com/Netflix/hubcommander/blob/develop/publish_via_travis.sh#L36-L49 this so that we have a tag for stable/release, and one for unstable/development.

mikegrima avatar Dec 28 '17 15:12 mikegrima

True, I was in the mindset of creating an automated build in docker hub but your solution fits better with the current CI, I'll open another PR for it soon.

yaron-idan avatar Dec 28 '17 18:12 yaron-idan