go-expect icon indicating copy to clipboard operation
go-expect copied to clipboard

Update example code to use `x/term` instead of `x/crypto/ssh/terminal`

Open y-yagi opened this issue 4 years ago • 2 comments

Because x/crypto/ssh/terminal is deprecated and moved to x/term. https://pkg.go.dev/golang.org/x/crypto/ssh/terminal#pkg-overview

y-yagi avatar Oct 08 '21 02:10 y-yagi

This will break compatibility with Go 1.13 though, is that right?

hinshun avatar Oct 10 '21 02:10 hinshun

ssh/terminal is just the wrapper of x/term. https://github.com/golang/crypto/blob/master/ssh/terminal/terminal.go

So the code that was originally working keeps working and doesn't break compatibility with Go 1.13 I think(I could confirm that the updated example code working with Go 1.13).

y-yagi avatar Oct 10 '21 03:10 y-yagi