dgs-framework

dgs-framework copied to clipboard

Pull request checklist

• [x] Please read our contributor guide
• [x] Consider creating a discussion on the discussion forum first
• [ ] Make sure the PR doesn't introduce backward compatibility issues
• [x] Make sure to have sufficient test cases

Pull Request type

• [x] Bugfix
• [x] Feature
• [x] Refactoring (no functional changes, no api changes) <---
• [ ] Build related changes
• [ ] Other (please describe):

Changes in this PR

Fixes problems arising from https://github.com/Netflix/dgs-framework/issues/905 (will update description later)

Screenshots:

WebFlux smoke test (without Caffeine support):

WebMvc smoke test (with Caffeine support):

Alternatives considered

N/A

cc @berngp

Ping @berngp

This pull request has been marked as stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 7 days

@berngp is there still interest from Netflix in integrating this?

If yes I'll update it one last time

Otherwise, I'll close it :)

@jord1e - Thanks so much for all the work. We won't be investing in this effort at this time due to other internal priorities. Internally, we use APQ differently and do not require APQ support on our DGSs at the moment. Feel free to close the PR and we will reopen at a more convenient time.

I've run back my original issue, while upgrading to spring boot 3 and bringing in these dependencies:

        <dependency>
            <groupId>jakarta.ws.rs</groupId>
            <artifactId>jakarta.ws.rs-api</artifactId>
            <version>3.1.0</version>
        </dependency>
        <dependency>
            <groupId>org.glassfish.jersey.core</groupId>
            <artifactId>jersey-client</artifactId>
            <version>3.1.0</version>
        </dependency>
        <dependency>
            <groupId>org.glassfish.jersey.inject</groupId>
            <artifactId>jersey-hk2</artifactId>
            <version>3.1.0</version>
        </dependency>

Any chance we could get this merged in? Or is it going to break your integration? @srinivasankavitha

@Ancient-Dragon - we won't be merging this PR at this time since we are not using this feature and have conflicting internal priorities to invest in.