Netanel Basal comments

Results 282 comments of


                                            Netanel Basal

randPhoneNumber will generate invalid US phone numbers

You're welcome to create a PR

Testing for functional guards

You are welcome to play with some ideas you have and see what's the best fit and open a PR.

feat(spectator): support defer block behavior

Thanks, great work!

fix(spectator): make mock template type safe (#607)

I'd love to see basic types test. You can use the same library I'm using [here](https://github.com/ngneat/elf/blob/master/packages/store/src/lib/types.spec.ts#L42)

Template object type safety in createSpyObject

We can release a new major version.

Error: NG0203 when using inject() in abstract base class member

Does it work with plain Angular?

Form is marked dirty when dropdown is pre-populated

Both the form and the source should be the same value, so you probably should update also the source value.

Form is marked dirty when dropdown is pre-populated

Can you create a simple reproduction on stackblitz?

Update the form when the queryParams are updated

@shaharkazaz can you take this discussion?

feat: 🎸 added option to handle prev/next button in the browser

Please add test